deps(lambda-rs-platform): Update wgpu and naga to v29.0.0#199
Merged
Conversation
… make a few adjustments where needed
✅ Coverage Report📊 View Full HTML Report (download artifact) Overall Coverage
Changed Files in This PR
PR Files Coverage: 67.16% (998/1486 lines) Generated by cargo-llvm-cov · Latest main coverage Last updated: 2026-03-25 18:14:25 UTC · Commit: |
There was a problem hiding this comment.
Pull request overview
Upgrades the lambda-rs-platform wgpu integration to wgpu/naga 29.0.0, updating wrapper APIs and surface acquisition behavior to match the new upstream interfaces.
Changes:
- Bump
wgpu+nagato29.0.0and refreshCargo.lock. - Update instance creation, pipeline layout creation, and depth/stencil state configuration to the wgpu v29 APIs.
- Update unsafe surface creation and surface frame acquisition/error handling (including new occlusion/validation error variants and suboptimal frame detection).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/lambda-rs/src/render/targets/surface.rs | Adds Occluded/Validation surface error variants, updates conversion + tests. |
| crates/lambda-rs/src/render/surface.rs | Mirrors new surface error variants and updates conversion + tests. |
| crates/lambda-rs-platform/src/wgpu/surface.rs | Updates surface creation handle shape and get_current_texture handling; tracks suboptimal frames. |
| crates/lambda-rs-platform/src/wgpu/render_pass.rs | Updates inline docs to remove version-specific wording. |
| crates/lambda-rs-platform/src/wgpu/pipeline.rs | Adapts pipeline layout bind group layout list and depth/stencil option fields for wgpu v29. |
| crates/lambda-rs-platform/src/wgpu/instance.rs | Updates wgpu::Instance construction to new InstanceDescriptor/Instance::new signature. |
| crates/lambda-rs-platform/src/wgpu/gpu.rs | Removes unnecessary conversion for max_uniform_buffer_binding_size under wgpu v29 types. |
| crates/lambda-rs-platform/Cargo.toml | Pins wgpu + naga to =29.0.0. |
| Cargo.lock | Lockfile refresh to resolve the new dependency graph for wgpu/naga v29. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
nagaandwgputo29.0.0and update thelambda-rs-platformwgpuintegration to compile and behave correctly with the new APIs.This includes wrapper changes required for instance creation, pipeline layout/depth state configuration,
surface creation, and surface frame acquisition/error handling.
Related Issues
None.
Changes
nagaandwgputo29.0.0inlambda-rs-platformand refreshCargo.lockwgpu::Instanceconstruction for the newInstanceDescriptorAPIwgpu29 optional depth fieldsCurrentSurfaceTextureacquisition results fromwgpu29OccludedandValidationsurface error variantsu64conversionType of Change
Affected Crates
lambda-rslambda-rs-platformlambda-rs-argslambda-rs-loggingChecklist
cargo +nightly fmt --all)cargo clippy --workspace --all-targets -- -D warnings)cargo test --workspace)Testing
Commands run:
Screenshots/Recordings
Not applicable.
Platform Testing
Additional Notes